Jackie-Jiang commented on code in PR #18904:
URL: https://github.com/apache/pinot/pull/18904#discussion_r3509493794
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java:
##########
@@ -198,11 +196,13 @@ public StreamConfig(String tableNameWithType, Map<String,
String> streamConfigMa
}
_flushAutotuneInitialRows = autotuneInitialRows > 0 ? autotuneInitialRows
: DEFAULT_FLUSH_AUTOTUNE_INITIAL_ROWS;
- String groupIdKey = StreamConfigProperties.constructStreamProperty(_type,
StreamConfigProperties.GROUP_ID);
- _groupId = streamConfigMap.get(groupIdKey);
+ String partitionRate =
streamConfigMap.get(StreamConfigProperties.PARTITION_CONSUMPTION_RATE_LIMIT);
+ _partitionConsumptionRateLimit =
+ partitionRate != null ? Double.parseDouble(partitionRate) :
CONSUMPTION_RATE_LIMIT_NOT_SPECIFIED;
Review Comment:
This matches the existing parsing behavior of the topic level rate limit
(and the general parsing style in this class). A malformed value throws
`NumberFormatException` with the offending string at table config processing
time, same as before. Non-finite values fall into the non-positive check and
are treated as not throttled, which is a safe fallback. Not worth adding extra
validation just for this config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
