xiangfu0 commented on code in PR #18185:
URL: https://github.com/apache/pinot/pull/18185#discussion_r3569038250


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV4.java:
##########
@@ -92,6 +92,8 @@ public class VarByteChunkForwardIndexWriterV4 implements 
VarByteChunkWriter {
   private int _nextDocId = 0;
   private int _metadataSize = 0;
   private long _chunkOffset = 0;
+  private long _uncompressedSize = 0;
+  private boolean _trackUncompressedSize = true;

Review Comment:
   Addressed on the current head. V4 tracking now defaults to `false` and is 
enabled explicitly through 
`enableRawForwardIndexUncompressedValueSizeTracking()` only when the 
table-level feature flag is on. Disabled-path coverage includes V4/V5/V6 
behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to