xiangfu0 commented on PR #18185: URL: https://github.com/apache/pinot/pull/18185#issuecomment-4940782360
Pushed follow-up fixes to the PR branch at `1b75792e0b53ed4eb26e8aa35897bc103d8722de`. Addressed: - Treat dictionary presence separately from forward-index encoding in server compression stats, so `HAS_DICTIONARY=true` + raw forward index is reported as raw compression stats instead of `DICT_ENCODED`. - Persist raw forward compression stats when reload flips a dict-encoded forward index to raw while retaining the dictionary. - Count fixed-width MV dictionary raw-ingest bytes by total element count, not document count. - Avoid mutating tier metric tracking on non-leader table-size reads. Validation: - `./mvnw -pl pinot-segment-local -am -Dtest=SegmentDictionaryCreatorRawIngestSizeTest,ForwardIndexHandlerCompressionStatsTest -Dsurefire.failIfNoSpecifiedTests=false test` - `./mvnw -pl pinot-controller -am -Dskip.npm=true -Dtest=TableSizeReaderCompressionStatsTest -Dsurefire.failIfNoSpecifiedTests=false test` - `./mvnw -pl pinot-server -am -Dtest=TableSizeResourceTest,TablesResourceTest -Dsurefire.failIfNoSpecifiedTests=false test` - `./mvnw spotless:apply -pl pinot-controller,pinot-segment-local,pinot-server` - `./mvnw checkstyle:check -pl pinot-controller,pinot-segment-local,pinot-server` - `./mvnw license:format -pl pinot-controller,pinot-segment-local,pinot-server` - `./mvnw license:check -pl pinot-controller,pinot-segment-local,pinot-server` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
