xiangfu0 commented on PR #18185: URL: https://github.com/apache/pinot/pull/18185#issuecomment-4955836124
Updated the PR to commit `3b47f0b042ad9b0e7fe7e5402ac5700df576c67d`. - rebased onto current `apache/master` and squashed the incremental history to one commit - addressed the two items from review `pullrequestreview-4649696883`: request-level column filtering now controls controller-to-server fan-out, and both offline/realtime integration coverage use the shared custom cluster - replied to and resolved all six remaining review threads - updated the PR body and PEP to the final API, metadata, bounded fan-out, rolling-upgrade, and metric contracts - added the user manual and complete sample table configuration - completed fresh reviews across config/backcompat, concurrency/state, architecture, performance, correctness/nulls, testing, naming/API, and process/scope with no remaining findings Local validation completed: - 74 focused controller tests - focused common, segment, server, and controller suites - full `pinot-integration-tests` dependency-graph test compilation - Spotless, Checkstyle, license format, and license check for all nine affected modules Requested @Jackie-Jiang for forward-index/segment ownership review. CI is restarting on the rewritten head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
