VojtechMucha commented on PR #19035: URL: https://github.com/apache/pinot/pull/19035#issuecomment-5280664959
> **Major (pre-existing gap, cheap to close here) — `getObject` throws for scalar `BIG_DECIMAL` / `TIMESTAMP` / `JSON`** (both `PinotResultSet` and `PinotGrpcResultSet` switches) > > The rewritten switch covers STRING/INT/LONG/FLOAT/DOUBLE/BOOLEAN/BYTES/MAP; all other enum constants hit `default: throw`. `DriverUtils.getSQLDataType`/`getJavaClassName` advertise these types (`Types.DECIMAL`/`BigDecimal`, `Types.TIMESTAMP`/`Timestamp`), so metadata promises a value the accessor refuses. The old switch had the same gap, so this is not a regression — but since you're rebuilding the switch it's a cheap fix: > > ```java > case BIG_DECIMAL: return getBigDecimal(columnIndex); > case TIMESTAMP: return getTimestamp(columnIndex); > case JSON: return getString(columnIndex); > ``` > > If you'd rather keep scope tight, that's reasonable — just call it out explicitly rather than leaving it silent. Sure, I added these types too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
