VojtechMucha commented on PR #19035:
URL: https://github.com/apache/pinot/pull/19035#issuecomment-5280256281

   > **Major — `UUID_ARRAY` throws a self-contradictory error** 
(`PinotResultSet.java` `getList` default, and the same in 
`PinotGrpcResultSet.java` `getList`)
   > 
   > `ColumnDataType.UUID_ARRAY` is in `ARRAY_TYPES`, so `isArray()` returns 
`true` and `getObject` dispatches it to `getList`, which has no `UUID_ARRAY` 
case → `default: throw new SQLDataException("Data type is not an array: 
UUID_ARRAY")`, which is factually wrong (it _is_ an array). Meanwhile 
`DriverUtils.isArrayDataType("UUID_ARRAY")` returns `true`, so metadata 
advertises `Types.JAVA_OBJECT`/`List` while the accessor throws.
   > 
   > Fix: add a `case UUID_ARRAY:` (both decoders yield `String[]`, so treat 
like `STRING_ARRAY`), or exclude it from `isArrayDataType` so metadata and 
accessor agree. At minimum reword the default message to `"Unsupported array 
data type: " + dataType`.
   
   `UUID` types are pretty new. I added both `UUID` and `UUID_ARRAY`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to