VojtechMucha commented on PR #19035: URL: https://github.com/apache/pinot/pull/19035#issuecomment-5280704516
> **Major — test-coverage gaps** > > * **MAP is untested on the HTTP path** — the `case MAP:` → `parseJson(MAP_READER)` branch in `PinotResultSet` is never exercised (gRPC covers MAP; HTTP does not). > * **No negative/error-path tests** on either path: malformed JSON, bad hex (`DecoderException`), bad timestamp (`ParseException`), bad decimal (`NumberFormatException`), unknown type name, and gRPC non-Map value / `ClassCastException` are all vacuously green. Add `assertThrows(SQLDataException.class, ...)` for each. > * **gRPC null/`wasNull` parity**: the HTTP suite has `testNullAndEmptyArrays` asserting a null array + `wasNull()`, but the gRPC suite only tests empty arrays — never a null array/map, and never asserts `wasNull()`, so gRPC's `getValue()` null bookkeeping is untested. The test coverage is improved now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
