xiangfu0 commented on code in PR #19894:
URL: https://github.com/apache/pinot/pull/19894#discussion_r4289533553
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/VectorIndexUtils.java:
##########
@@ -325,6 +326,8 @@ public static VectorSimilarityFunction toSimilarityFunction(
public static IndexWriterConfig getIndexWriterConfig(VectorIndexConfig
vectorIndexConfig) {
IndexWriterConfig indexWriterConfig = new IndexWriterConfig();
+ // Lucene 10 disables this by default; retain the previous merge I/O
throttling behavior.
+ ((ConcurrentMergeScheduler)
indexWriterConfig.getMergeScheduler()).enableAutoIOThrottle();
Review Comment:
Addressed in 83263d62ca: the vector writer now constructs and installs
ConcurrentMergeScheduler explicitly, matching the text creators.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/vector/lucene99/HnswCodec.java:
##########
@@ -69,10 +69,11 @@ public KnnVectorsFormat getKnnVectorsFormatForField(String
field) {
/// Instantiates a new codec, specifying the stored fields compression mode
to use.
///
/// @param mode stored fields compression mode to use for newly
flushed/merged segments.
- public HnswCodec(Lucene912Codec.Mode mode, KnnVectorsFormat
defaultKnnVectorsFormat) {
- super("Lucene99", new Lucene912Codec(mode));
+ public HnswCodec(Lucene100Codec.Mode mode, KnnVectorsFormat
defaultKnnVectorsFormat) {
+ // Legacy indexes retain the Lucene99 name and are read by
lucene-backward-codecs.
+ super("Lucene100", new Lucene100Codec(mode));
Review Comment:
Addressed in 83263d62ca: the constructor comment now states that new indexes
use Lucene100 format and legacy Lucene99 indexes use backward codecs. Both
write/read paths passed focused validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
