xiangfu0 commented on code in PR #19894:
URL: https://github.com/apache/pinot/pull/19894#discussion_r4290723950
##########
.github/workflows/pinot_compatibility_checks.yml:
##########
@@ -48,32 +46,53 @@ concurrency:
cancel-in-progress: true
jobs:
- binary-compat-check:
+ compatibility-baselines:
if: github.repository == 'apache/pinot'
runs-on: ubuntu-latest
- name: Pinot Binary Compatibility Check
+ outputs:
+ sha: ${{ steps.baseline.outputs.sha }}
+ runtime_commits: ${{ steps.baseline.outputs.runtime_commits }}
steps:
- uses: actions/[email protected]
with:
fetch-depth: 2
- - name: Select binary compatibility baseline
- id: binary-baseline
+ - name: Select compatibility baselines
+ id: baseline
env:
PUSH_BEFORE_SHA: ${{ github.event.before }}
run: |
if [[ "$GITHUB_EVENT_NAME" == "pull_request" ]]; then
- # Compare against the master snapshot actually included in the
tested merge.
+ # Compare against the base snapshot actually included in the
tested merge.
BASELINE=$(git rev-parse HEAD^1)
else
# A push can contain multiple commits, so compare the entire
pushed range.
BASELINE="$PUSH_BEFORE_SHA"
fi
if [[ -z "$BASELINE" || "$BASELINE" ==
"0000000000000000000000000000000000000000" ]]; then
- echo "::error::No previous commit is available for the binary
compatibility baseline"
+ echo "::error::No previous commit is available for the
compatibility baseline"
exit 1
fi
echo "Comparing baseline $BASELINE against $(git rev-parse HEAD)"
echo "sha=$BASELINE" >> "$GITHUB_OUTPUT"
+ # #19900 is the minimum Lucene 9.12 rollback target for Lucene 10
writers.
+ # Unpatched releases (including 1.5.0) cannot read the newly
generated Lucene indexes.
+ RECOVERY_BASELINE_SHA=fbe82e7e25a4b5c642c75ecf42d6f62b884174e5
Review Comment:
This pins an unmerged PR commit (#19900) as the rollback baseline, and this
commit also drops the `branches: master` PR filters on several workflows. Both
look like stacked-PR CI scaffolding — worth reverting (or swapping the SHA for
the merged commit) before this lands on master so CI doesn't keep depending on
an unmerged ref.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
