xiangfu0 commented on code in PR #19894:
URL: https://github.com/apache/pinot/pull/19894#discussion_r4300521169
##########
.github/workflows/pinot_compatibility_checks.yml:
##########
@@ -191,16 +210,15 @@ jobs:
--ignore-missing-classes
done
compatibility-verifier:
+ needs: compatibility-baselines
if: github.repository == 'apache/pinot'
runs-on: ubuntu-latest
strategy:
# Changed to false in order to improve coverage using unsafe buffers
fail-fast: false
matrix:
test_suite: [ "compatibility-verifier/sample-test-suite" ]
- old_commit: [
- "release-1.5.0", "master"
- ]
+ old_commit: ${{
fromJSON(needs.compatibility-baselines.outputs.runtime_commits) }}
Review Comment:
README now explicitly names Pinot 1.5.0 as an unsupported rollback target
and requires a patched Lucene9.12 build containing merged #19900. A merge is
not a released build; operators must deploy that recovery-capable build before
upgrading. The full rollback CI uses the merged recovery commit rather than the
unpatched release.
##########
.github/workflows/pinot_compatibility_checks.yml:
##########
@@ -32,8 +32,6 @@ on:
- "licenses-binary/**"
- "**.md"
pull_request:
- branches:
- - master
paths-ignore:
Review Comment:
Restored the master-only pull_request filters in all six workflows in
8a2ba18849. The PR is now based directly on master, so the stacking exception
is no longer needed. Actionlint and trigger assertions passed.
##########
.github/workflows/scripts/.pinot_compatibility_verifier.sh:
##########
@@ -75,7 +75,12 @@ NEW_COMMIT_HASH=$(commitHash HEAD)
if [ ! -z "${NEW_COMMIT}" ]; then
NEW_COMMIT_HASH=$(commitHash "${NEW_COMMIT}")
fi
-OLD_COMMIT_HASH=$(commitHash "${OLD_COMMIT}")
+OLD_COMMIT_HASH=$(commitHash "${OLD_COMMIT}") || OLD_COMMIT_HASH=""
+# A pinned rollback baseline may be an unmerged PR commit, absent from master
and tags.
+if [ -z "${OLD_COMMIT_HASH}" ]; then
Review Comment:
The pinned baseline is now merged master ancestor
a45ebf01379257591c27c900c3525612a3c49b92, so it no longer depends on an
unmerged PR head. The fetch fallback remains useful for shallow checkouts and
other historical baselines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
