snleee commented on code in PR #9309:
URL: https://github.com/apache/pinot/pull/9309#discussion_r976862985


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -680,6 +680,7 @@ public static class Offline {
     public static class AssignmentStrategy {
       public static final String BALANCE_NUM_SEGMENT_ASSIGNMENT_STRATEGY = 
"BalanceNumSegmentAssignmentStrategy";
       public static final String REPLICA_GROUP_SEGMENT_ASSIGNMENT_STRATEGY = 
"ReplicaGroupSegmentAssignmentStrategy";
+      public static final String DIM_TABLE_SEGMENT_ASSIGNMENT_STRATEGY = 
"DimTableSegmentAssignmentStrategy";

Review Comment:
   also, are we covering the different cases? we can make all of the following 
to work. `e.g. balanced, Balanced, BaLanCed...etc`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to