walterddr commented on code in PR #9773: URL: https://github.com/apache/pinot/pull/9773#discussion_r1019327467
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/BlockSplitter.java: ########## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.blocks; + +import java.util.List; +import org.apache.pinot.common.datablock.BaseDataBlock; + + +/** + * Interface for splitting transferable blocks. This is used for ensuring + * that the blocks that are sent along the wire play nicely with the + * underlying transport. + */ +public interface BlockSplitter { + + /** + * @return a list of blocks that was split from the original {@code block} + */ + List<TransferableBlock> split(TransferableBlock block, BaseDataBlock.Type type, int maxBlockSize); Review Comment: (major) this design is cleaner but i also wonder if this introduces unnecessary looping of the dataset. for example, hash distribution + split block loops over the entire data set twice instead of once. although we are not doing it now, we can potentially (1) partition by key and (2) put them in split block, (3) and even send them over the wire, at a single loop. but i am not sure how to achieve that in these interface settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
