agavra commented on PR #9773: URL: https://github.com/apache/pinot/pull/9773#issuecomment-1312902006
@61yao this PR cannot meaningfully be broken into smaller PRs - it splits a single file into five and adds tests for those additional files. any additional split would require adding unnecessary abstractions. As an aside, I don't think it's that big at all - about 200 lines are just file headers for newly created files and 500 lines are test-only code (so it's really only about 200/300 lines of production code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
