walterddr commented on code in PR #10315:
URL: https://github.com/apache/pinot/pull/10315#discussion_r1113416904
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -109,10 +109,17 @@ private static String removeTerminatingSemicolon(String
sql) {
public static SqlNodeAndOptions compileToSqlNodeAndOptions(String sql)
throws SqlCompilationException {
+ return compileToSqlNodeAndOptions(sql, true);
+ }
+
+ public static SqlNodeAndOptions compileToSqlNodeAndOptions(String sql,
boolean isRemoveComments)
+ throws SqlCompilationException {
long parseStartTimeNs = System.nanoTime();
// Remove the comments from the query
Review Comment:
no we are still supporting OPTIONS until next release :-/ so we can't remove
it now unfortunately lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
