walterddr commented on code in PR #10315:
URL: https://github.com/apache/pinot/pull/10315#discussion_r1113547117
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotAggregateExchangeNodeInsertRule.java:
##########
@@ -83,8 +83,8 @@ public boolean matches(RelOptRuleCall call) {
}
if (call.rel(0) instanceof Aggregate) {
Aggregate agg = call.rel(0);
- return !agg.getHints().contains(PinotRelationalHints.AGG_LEAF_STAGE)
- &&
!agg.getHints().contains(PinotRelationalHints.AGG_INTERMEDIATE_STAGE);
+ return !agg.getHints().contains(AggregateNode.INTERMEDIATE_STAGE_HINT)
Review Comment:
not really. as i mentioned above these 2 hints are not suppose to be
directly used by user. this PR only changes the relhint to sqlhint. we are
actually not planning to open these 2 up to users.
do you prefer me changing this to a more explicit internal wording?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
