walterddr commented on code in PR #10315:
URL: https://github.com/apache/pinot/pull/10315#discussion_r1113793078
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/hint/PinotHintStrategyTable.java:
##########
@@ -16,19 +16,21 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.query.planner.hints;
-
-import org.apache.calcite.rel.hint.RelHint;
-
+package org.apache.calcite.rel.hint;
/**
- * Provide certain relational hint to query planner for better optimization.
+ * Default hint strategy set for Pinot query.
*/
-public class PinotRelationalHints {
- public static final RelHint AGG_INTERMEDIATE_STAGE =
RelHint.builder("AGG_INTERMEDIATE_STAGE").build();
- public static final RelHint AGG_LEAF_STAGE =
RelHint.builder("AGG_LEAF_STAGE").build();
+public class PinotHintStrategyTable {
+ public static final String INTERNAL_AGG_INTERMEDIATE_STAGE =
"aggIntermediateStage";
+ public static final String INTERNAL_AGG_FINAL_STAGE = "aggFinalStage";
Review Comment:
actually let's defer this decision to later. b/c the current framework adds
INTERNAL_* RelHints that are most likely going to be hintName without options
(neither kvOptions or listOptions)
we can explicitly add static classes for listOptions and kvOptions later,
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
