61yao commented on code in PR #10350:
URL: https://github.com/apache/pinot/pull/10350#discussion_r1122377836
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java:
##########
@@ -51,7 +51,8 @@ public BalancedInstanceSelector(String tableNameWithType,
BrokerMetrics brokerMe
@Override
Map<String, String> select(List<String> segments, int requestId,
- Map<String, List<String>> segmentToEnabledInstancesMap, Map<String,
String> queryOptions) {
+ Map<String, List<String>> segmentToEnabledInstancesMap, Map<String,
String> queryOptions,
+ long nowMillis) {
Review Comment:
Because we want to use the same timestamp to check new segment age for both
segment instance assignment and unavailable segment reporting. The other thing
is getting clock time is system call. it is not cheap.
The new segments are processed only in StrictReplicaGroup. I didn't change
the behavior for other selector.
New segments information are directly used through private member in
StrictReplicaGroup and thus we don't need passing.
Please see the implementation for StrictReplicaGroup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
