61yao commented on code in PR #10350:
URL: https://github.com/apache/pinot/pull/10350#discussion_r1122384566
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java:
##########
@@ -51,7 +51,8 @@ public BalancedInstanceSelector(String tableNameWithType,
BrokerMetrics brokerMe
@Override
Map<String, String> select(List<String> segments, int requestId,
- Map<String, List<String>> segmentToEnabledInstancesMap, Map<String,
String> queryOptions) {
+ Map<String, List<String>> segmentToEnabledInstancesMap, Map<String,
String> queryOptions,
+ long nowMillis) {
Review Comment:
Hmm.. I probably should pass new segment info to be thread safe. Let me
update the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
