61yao commented on code in PR #10350:
URL: https://github.com/apache/pinot/pull/10350#discussion_r1137544792
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -617,7 +617,8 @@ protected void waitForDocsLoaded(long timeoutMs, boolean
raiseError, String tabl
@Override
public Boolean apply(@Nullable Void aVoid) {
try {
- return getCurrentCountStarResult(tableName) == countStarResult;
+ long curCount = getCurrentCountStarResult(tableName);
Review Comment:
done
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -113,18 +114,27 @@ public static class Helix {
public static final String UNTAGGED_MINION_INSTANCE = "minion_untagged";
public static class StateModel {
+ // public only for testing purpose.
+ public static final long NEW_SEGMENT_EXPIRATION_MILLIS =
TimeUnit.MINUTES.toMillis(5);
public static class SegmentStateModel {
public static final String ONLINE = "ONLINE";
public static final String OFFLINE = "OFFLINE";
public static final String ERROR = "ERROR";
public static final String CONSUMING = "CONSUMING";
+ public static boolean isOnline(String state) {
+ return state.equals(ONLINE) || state.equals(CONSUMING);
+ }
}
public static class BrokerResourceStateModel {
public static final String ONLINE = "ONLINE";
public static final String OFFLINE = "OFFLINE";
public static final String ERROR = "ERROR";
}
+
+ public static boolean isNewSegment(long creationTimeMillis, long
nowMillis) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
