somandal commented on code in PR #10846:
URL: https://github.com/apache/pinot/pull/10846#discussion_r1219868444
##########
pinot-query-planner/src/main/java/org/apache/calcite/sql/fun/PinotOperatorTable.java:
##########
@@ -103,6 +98,61 @@ public final void initNoDuplicate() {
throw Util.throwAsRuntime(Util.causeOrSelf(e));
}
}
+
+ // Walk through all the Pinot aggregation types and register those that
are supported in multistage and which
+ // aren't standard Calcite functions such as SUM / MIN / MAX / COUNT etc.
+ for (AggregationFunctionType aggregationFunctionType :
AggregationFunctionType.values()) {
+ if (aggregationFunctionType.isNativeCalciteAggregationFunctionType()
+ || !aggregationFunctionType.isSupportedInMultiStage()) {
Review Comment:
I think I can derive this from the other fields in the enum so let me try
that route before maintaining either kind of list. there are over 65
aggregation functions, so any list will eventually be impractical to maintain,
even if temporary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
