somandal commented on code in PR #10846:
URL: https://github.com/apache/pinot/pull/10846#discussion_r1248091869
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseSingleInputAggregationFunction.java:
##########
@@ -40,7 +40,7 @@ public BaseSingleInputAggregationFunction(ExpressionContext
expression) {
@Override
public String getResultColumnName() {
- return getType().getName().toLowerCase() + "(" + _expression + ")";
+ return getType().getName().replace("_", "").toLowerCase() + "(" +
_expression + ")";
Review Comment:
none of the v1 aggregation function have an '_' in their name so this should
be fine. This was added to handle backward incompatibility for BOOL_AND and
BOOL_OR which are named with underscore in v2 but don't have an underscore in
v1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
