somandal commented on code in PR #10846:
URL: https://github.com/apache/pinot/pull/10846#discussion_r1248289893
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseSingleInputAggregationFunction.java:
##########
@@ -40,7 +40,7 @@ public BaseSingleInputAggregationFunction(ExpressionContext
expression) {
@Override
public String getResultColumnName() {
- return getType().getName().toLowerCase() + "(" + _expression + ")";
+ return getType().getName().replace("_", "").toLowerCase() + "(" +
_expression + ")";
Review Comment:
discussed offline - now we register both names without and without the
underscore. removed this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
