walterddr commented on code in PR #10846:
URL: https://github.com/apache/pinot/pull/10846#discussion_r1248908947
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java:
##########
@@ -188,60 +191,27 @@ public void
shouldAggregateSingleInputBlockWithLiteralInput() {
Assert.assertTrue(block2.isEndOfStreamBlock(), "Second block is EOS (done
processing)");
}
- @Test
- public void shouldCallMergerWhenAggregatingMultipleRows() {
- // Given:
- List<RexExpression> calls = ImmutableList.of(getSum(new
RexExpression.InputRef(1)));
- List<RexExpression> group = ImmutableList.of(new
RexExpression.InputRef(0));
-
- DataSchema inSchema = new DataSchema(new String[]{"group", "arg"}, new
ColumnDataType[]{INT, INT});
- Mockito.when(_input.nextBlock())
- .thenReturn(OperatorTestUtil.block(inSchema, new Object[]{1, 1}, new
Object[]{1, 1}))
- .thenReturn(OperatorTestUtil.block(inSchema, new Object[]{1, 1}))
- .thenReturn(TransferableBlockUtils.getEndOfStreamTransferableBlock());
-
- AggregationUtils.Merger merger =
Mockito.mock(AggregationUtils.Merger.class);
- Mockito.when(merger.merge(Mockito.any(), Mockito.any())).thenReturn(12d);
- Mockito.when(merger.init(Mockito.any(), Mockito.any())).thenReturn(1d);
- DataSchema outSchema = new DataSchema(new String[]{"sum"}, new
ColumnDataType[]{DOUBLE});
- AggregateOperator operator =
- new AggregateOperator(OperatorTestUtil.getDefaultContext(), _input,
outSchema, calls, group, inSchema,
- ImmutableMap.of("SUM", cdt -> merger));
Review Comment:
This test is no longer allowed as we do not have a merger API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
