Jackie-Jiang commented on code in PR #11763:
URL: https://github.com/apache/pinot/pull/11763#discussion_r1358915901
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java:
##########
@@ -493,9 +493,13 @@ private static String getErrorMessage(HttpUriRequest
request, CloseableHttpRespo
String reason;
try {
String entityStr = EntityUtils.toString(response.getEntity());
- reason = JsonUtils.stringToObject(entityStr,
SimpleHttpErrorInfo.class).getError();
+ try {
+ reason = JsonUtils.stringToObject(entityStr,
SimpleHttpErrorInfo.class).getError();
+ } catch (Exception e) {
+ reason = entityStr;
+ }
Review Comment:
Not directly relevant, but find this not able to return the error during
debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
