Jackie-Jiang commented on code in PR #11763:
URL: https://github.com/apache/pinot/pull/11763#discussion_r1358917066
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java:
##########
@@ -111,8 +111,8 @@ public static AggregationFunction
getAggregationFunction(FunctionContext functio
} else if (numArguments == 2) {
// Double arguments percentile (e.g. percentile(foo, 99),
percentileTDigest(bar, 95), etc.) where the
// second argument is a decimal number from 0.0 to 100.0.
- // Have to use literal string because we need to cast int to double
here.
- double percentile =
parsePercentileToDouble(arguments.get(1).getLiteral().getStringValue());
+ double percentile = arguments.get(1).getLiteral().getDoubleValue();
Review Comment:
This is for `percentile(col, 99.5)` which is allowed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
