Jackie-Jiang commented on code in PR #11763:
URL: https://github.com/apache/pinot/pull/11763#discussion_r1358916446
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -116,15 +116,22 @@ public static Expression getLiteralExpression(SqlLiteral
node) {
Expression expression = new Expression(ExpressionType.LITERAL);
Literal literal = new Literal();
if (node instanceof SqlNumericLiteral) {
- // TODO: support different integer and floating point type.
- // Mitigate calcite NPE bug, we need to check if
SqlNumericLiteral.getScale() is null before calling
- // SqlNumericLiteral.isInteger(). TODO: Undo this fix once a Calcite
release that contains CALCITE-4199 is
- // available and Pinot has been upgraded to use such a release.
+ BigDecimal bigDecimalValue = node.bigDecimalValue();
+ assert bigDecimalValue != null;
SqlNumericLiteral sqlNumericLiteral = (SqlNumericLiteral) node;
- if (sqlNumericLiteral.getScale() != null &&
sqlNumericLiteral.isInteger()) {
- literal.setLongValue(node.bigDecimalValue().longValue());
+ if (sqlNumericLiteral.isExact() && sqlNumericLiteral.isInteger()) {
Review Comment:
This is incorrect. FLOAT/DOUBLE is not exact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
