tibrewalpratik17 commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1517442209
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -572,7 +573,7 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
// Decode message
StreamDataDecoderResult decodedRow =
_streamDataDecoder.decode(messagesAndOffsets.getStreamMessage(index));
msgMetadata = messagesAndOffsets.getStreamMessage(index).getMetadata();
- StreamPartitionMsgOffset messageOffset =
messagesAndOffsets.getNextStreamPartitionMsgOffsetAtIndex(index);
+ int messageOffset = messagesAndOffsets.getMessageOffsetAtIndex(index);
Review Comment:
I don't see it marked as deprecated and there is nothing similar to
`getNextStreamPartitionMsgOffsetAtIndex` which returns StreamPartitionMsgOffset
(it has long value). There can be scenarios of overflow.
Will wait for @satishd to chime in here as he might have more context on
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
