tibrewalpratik17 commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1523025620
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1743,6 +1752,12 @@ private void updateCurrentDocumentCountMetrics() {
rowsConsumed, consumedRate, _currentOffset, _numRowsConsumed,
_numRowsIndexed);
_lastConsumedCount = _numRowsConsumed;
_lastLogTime = now;
+ if (_filteredMessageOffsets.size() > 0) {
+ if (_trackFilteredMessageOffsets) {
+ _segmentLogger.info("Filtered events with offsets: {}",
_filteredMessageOffsets);
+ }
Review Comment:
self-review: adding a nested-if instead of combining it to ensure that
_filteredMessageOffsets gets clear every time just in case in future someone
changes the logic of pushing to _filteredMessageOffsets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
