Jackie-Jiang commented on code in PR #13217:
URL: https://github.com/apache/pinot/pull/13217#discussion_r1614056876
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java:
##########
@@ -162,7 +162,17 @@ public Object getValue() {
public boolean getBooleanValue() {
Boolean booleanValue = _booleanValue;
if (booleanValue == null) {
- booleanValue = _pinotDataType != null &&
_pinotDataType.toBoolean(_value);
+ if (_value instanceof Boolean) {
Review Comment:
Why do we need this? Are you trying to get boolean out of `NULL`? This won't
be accurate because `NULL` is not equivalent to boolean `false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
