Jackie-Jiang commented on code in PR #13217:
URL: https://github.com/apache/pinot/pull/13217#discussion_r1615313805
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpressionUtils.java:
##########
@@ -248,9 +248,11 @@ private static List<RexExpression>
toFunctionOperands(RexInputRef rexInputRef, S
public static RexExpression fromAggregateCall(AggregateCall aggregateCall) {
List<RexExpression> operands =
aggregateCall.getArgList().stream().map(RexExpression.InputRef::new).collect(Collectors.toList());
+ List<RexExpression> preArg =
+
aggregateCall.rexList.stream().map(RexExpressionUtils::fromRexNode).collect(Collectors.toList());
Review Comment:
Since it won't be backward compatible anyway, can we directly use this as
`operands`? I think that is the general way to handle it, where we already
support reading literal from operands
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
