xiangfu0 commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1615007974
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java: ########## @@ -117,6 +118,9 @@ class FunctionCall implements RexExpression { // whether the function is a distinct function. @ProtoProperties private boolean _isDistinct; + // the list of RexExpressions that represents the pre-args to the function. + @ProtoProperties + private List<RexExpression> _functionPreArgs; Review Comment: correct, it will break the query plan, e.g. intermediate stage result reference. So need to apply `_functionPreArgs` to `_functionOperands` during the query execution phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org