klsince commented on code in PR #13256:
URL: https://github.com/apache/pinot/pull/13256#discussion_r1626349679
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -959,7 +959,13 @@ AtomicBoolean getAcquiredConsumerSemaphore() {
@VisibleForTesting
SegmentBuildDescriptor buildSegmentInternal(boolean forCommit) {
- closeStreamConsumers();
+ // for partial upsert tables, do not release
_partitionGroupConsumerSemaphore proactively and rely on onDestroy()
Review Comment:
nit: looks like `offload()` closes the consumers
but anyway it looks right to me that the semaphore should be released in the
end, when the segment gets replaced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
