tibrewalpratik17 commented on code in PR #13256:
URL: https://github.com/apache/pinot/pull/13256#discussion_r1639419684
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactory.java:
##########
@@ -61,6 +64,12 @@ public static TableUpsertMetadataManager create(TableConfig
tableConfig,
upsertConfig.setEnablePreload(
Boolean.parseBoolean(instanceUpsertConfig.getProperty(UPSERT_DEFAULT_ENABLE_PRELOAD,
"false")));
}
+
+ // server level config honoured only when table level config is not set
to true
+ if (!upsertConfig.isAllowPartialUpsertConsumptionDuringCommit()) {
+
upsertConfig.setAllowPartialUpsertConsumptionDuringCommit(Boolean.parseBoolean(
+
instanceUpsertConfig.getProperty(UPSERT_DEFAULT_ALLOW_PARTIAL_UPSERT_CONSUMPTION_DURING_COMMIT,
"false")));
Review Comment:
Ah my bad! I see we have changed the behaviour from `pause` to `allow`. Then
this makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
