Jackie-Jiang commented on code in PR #13256:
URL: https://github.com/apache/pinot/pull/13256#discussion_r1626387944
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java:
##########
@@ -94,6 +94,9 @@ public enum ConsistencyMode {
@JsonPropertyDescription("Whether to drop out-of-order record")
private boolean _dropOutOfOrderRecord;
+ @JsonPropertyDescription("Whether to pause partial upsert table's partition
ingestion during commit")
+ private boolean _pausePartialUpsertPartitionIngestionDuringCommit;
Review Comment:
I think we should pause consumption by default. Consider renaming it to
`allowPartialUpsertConsumptionDuringCommit` and reverse the behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
