rohityadav1993 commented on code in PR #13107: URL: https://github.com/apache/pinot/pull/13107#discussion_r1630664998
########## pinot-common/src/main/java/org/apache/pinot/common/utils/UploadedRealtimeSegmentName.java: ########## @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.utils; + +import com.google.common.base.Joiner; +import com.google.common.base.Preconditions; +import java.util.Objects; +import javax.annotation.Nullable; +import org.apache.commons.lang3.StringUtils; +import org.joda.time.format.DateTimeFormat; +import org.joda.time.format.DateTimeFormatter; + + +/** + * Class to represent segment names like: {prefix}__{tableName}__{partitionId}__{creationTime}__{suffix} + * + * <p>This naming convention is adopted to represent a segment uploaded to a realtime table. The naming + * convention has been kept semantically similar to {@link LLCSegmentName} but differs in following ways: + * + * <li> prefix to quickly identify the type/source of segment e.g. "uploaded"/"minion" + * <li> tableName to be same as the table name of segment + * <li> partitionId to identify the right parition for upsert table segment table assignment. + * <li> creationTime creation time of segment of the format yyyyMMdd'T'HHmm'Z' + * <li> suffix to deduplicate segment names created at the same time + * + * Use {@link org.apache.pinot.segment.spi.creator.name.UploadedRealtimeSegmentNameGenerator} to generate segment names. + */ +public class UploadedRealtimeSegmentName implements Comparable<UploadedRealtimeSegmentName> { + + private static final String SEPARATOR = "__"; + private static final String DATE_FORMAT = "yyyyMMdd'T'HHmm'Z'"; + private static final DateTimeFormatter DATE_FORMATTER = DateTimeFormat.forPattern(DATE_FORMAT).withZoneUTC(); + private final String _prefix; + private final String _tableName; + private final int _partitionId; + private final String _creationTime; + private final String _segmentName; + private final String _suffix; + + public UploadedRealtimeSegmentName(String segmentName) { + + // split the segment name by the separator and get creation time, sequence id, partition id and table name from + // the end and validate segment name starts with prefix uploaded_ + try { + String[] parts = StringUtils.splitByWholeSeparator(segmentName, SEPARATOR); + Preconditions.checkState(parts.length == 5, + "Uploaded segment name must be of the format {prefix}__{tableName}__{partitionId}__{creationTime}__{suffix}"); + _prefix = parts[0]; + _tableName = parts[1]; + _partitionId = Integer.parseInt(parts[2]); + _creationTime = parts[3]; + _suffix = parts[4]; + _segmentName = segmentName; + } catch (NumberFormatException e) { + throw new IllegalArgumentException("Invalid segment name: " + segmentName, e); + } + } + + /** + * Constructor for UploadedRealtimeSegmentName. + * @param tableName + * @param partitionId + * @param msSinceEpoch + * @param prefix + * @param suffix + */ + public UploadedRealtimeSegmentName(String tableName, int partitionId, long msSinceEpoch, String prefix, + String suffix) { + Preconditions.checkArgument( + StringUtils.isNotBlank(tableName) && StringUtils.isNotBlank(prefix) && StringUtils.isNotBlank(suffix), Review Comment: Ack, will also add this to UploadedRealtimeSegmentNameGenerator as a check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
