klsince commented on code in PR #13107: URL: https://github.com/apache/pinot/pull/13107#discussion_r1631741645
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/UploadedRealtimeSegmentNameGenerator.java: ########## @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.spi.creator.name; + +import com.google.common.base.Joiner; +import com.google.common.base.Preconditions; +import javax.annotation.Nullable; +import org.apache.commons.lang3.StringUtils; + + +/** + * Implementation for generating segment names of the format UploadedRealtimeSegmentName: + * {prefix}__{tableName}__{partitionId}__{creationTime}__{suffix} + * + * <p>This naming convention is adopted to represent uploaded segments to a realtime table see + * UploadedRealtimeSegmentName. The semantic is similar + * to LLCSegmentName. This naming convention should be preferred when the data is partitioned in offline generated + * segments and should be assigned based same as realtime segments of the table generated from stream. + */ +public class UploadedRealtimeSegmentNameGenerator implements SegmentNameGenerator { + + private static final String DELIMITER = "__"; + private final String _tableName; + private final int _partitionId; + // creation time must be in long and milliseconds since epoch to be consistent with creation.meta time for valid + // comparison in segment replace flow. + private final long _creationTimeMillis; + private final String _prefix; + + // if suffix is not set then sequenceId is used as segment name suffix + @Nullable + private final String _suffix; + + /** + * Creates a UploadedRealtimeSegmentNameGenerator + * @param tableName + * @param partitionId + * @param creationTimeMillis + * @param prefix + * @param suffix optional field for generator, if not specified then sequenceId is used as suffix + */ + public UploadedRealtimeSegmentNameGenerator(String tableName, int partitionId, long creationTimeMillis, String prefix, + @Nullable String suffix) { + Preconditions.checkArgument( + StringUtils.isNotBlank(tableName) && !tableName.contains(DELIMITER) && StringUtils.isNotBlank(prefix) + && !prefix.contains(DELIMITER), "Invalid tableName or prefix for UploadedRealtimeSegmentNameGenerator"); + Preconditions.checkArgument(creationTimeMillis > 0, "Creation time must be greater than 0"); + if (suffix != null) { + Preconditions.checkArgument(suffix.length() > 0 && !suffix.contains(DELIMITER), Review Comment: nit: `StringUtils.isNotBlank(suffix)` ########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java: ########## @@ -600,6 +616,11 @@ public String inferSegmentNameGeneratorType() { return BatchConfigProperties.SegmentNameGeneratorType.NORMALIZED_DATE; } + // if segment is externally partitioned + if (_uploadedSegmentPartitionId != -1) { Review Comment: may also want to check if the table is an upsert table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
