rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1632638123
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java:
##########
@@ -600,6 +616,11 @@ public String inferSegmentNameGeneratorType() {
return BatchConfigProperties.SegmentNameGeneratorType.NORMALIZED_DATE;
}
+ // if segment is externally partitioned
+ if (_uploadedSegmentPartitionId != -1) {
Review Comment:
Partitioning is also applicable for non-upsert realtime table(for query
routing). This check would restrict to upsert only tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
