somandal commented on code in PR #14894:
URL: https://github.com/apache/pinot/pull/14894#discussion_r1927428873
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java:
##########
@@ -81,44 +82,48 @@ public static ImmutableSegment load(File indexDir, ReadMode
readMode, TableConfi
throws Exception {
IndexLoadingConfig defaultIndexLoadingConfig = new
IndexLoadingConfig(tableConfig, schema);
defaultIndexLoadingConfig.setReadMode(readMode);
- return load(indexDir, defaultIndexLoadingConfig, false);
+ return load(indexDir, defaultIndexLoadingConfig, false, null);
}
/**
* Loads the segment with specified IndexLoadingConfig.
* This method modifies the segment like to convert segment format, add or
remove indices.
* Mostly used by UT cases to add some specific index for testing purpose.
*/
- public static ImmutableSegment load(File indexDir, IndexLoadingConfig
indexLoadingConfig)
+ public static ImmutableSegment load(File indexDir, IndexLoadingConfig
indexLoadingConfig,
+ SegmentPreprocessThrottler segmentPreprocessThrottler)
Review Comment:
done
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java:
##########
@@ -81,44 +82,48 @@ public static ImmutableSegment load(File indexDir, ReadMode
readMode, TableConfi
throws Exception {
IndexLoadingConfig defaultIndexLoadingConfig = new
IndexLoadingConfig(tableConfig, schema);
defaultIndexLoadingConfig.setReadMode(readMode);
- return load(indexDir, defaultIndexLoadingConfig, false);
+ return load(indexDir, defaultIndexLoadingConfig, false, null);
}
/**
* Loads the segment with specified IndexLoadingConfig.
* This method modifies the segment like to convert segment format, add or
remove indices.
* Mostly used by UT cases to add some specific index for testing purpose.
*/
- public static ImmutableSegment load(File indexDir, IndexLoadingConfig
indexLoadingConfig)
+ public static ImmutableSegment load(File indexDir, IndexLoadingConfig
indexLoadingConfig,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
