somandal commented on code in PR #14894:
URL: https://github.com/apache/pinot/pull/14894#discussion_r1927429117
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java:
##########
@@ -158,15 +163,25 @@ public static ImmutableSegment load(File indexDir,
IndexLoadingConfig indexLoadi
/**
* Preprocess the local segment directory according to the current table
config and schema.
*/
- public static void preprocess(File indexDir, IndexLoadingConfig
indexLoadingConfig, @Nullable Schema schema)
+ public static void preprocess(File indexDir, IndexLoadingConfig
indexLoadingConfig, @Nullable Schema schema,
+ SegmentPreprocessThrottler segmentPreprocessThrottler)
throws Exception {
Preconditions.checkArgument(indexDir.isDirectory(), "Index directory: %s
does not exist or is not a directory",
indexDir);
SegmentMetadataImpl segmentMetadata = new SegmentMetadataImpl(indexDir);
if (segmentMetadata.getTotalDocs() > 0) {
convertSegmentFormat(indexDir, indexLoadingConfig, segmentMetadata);
Review Comment:
done
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##########
@@ -53,7 +54,8 @@ public interface TableDataManager {
*/
void init(InstanceDataManagerConfig instanceDataManagerConfig, HelixManager
helixManager, SegmentLocks segmentLocks,
TableConfig tableConfig, @Nullable ExecutorService
segmentPreloadExecutor,
- @Nullable Cache<Pair<String, String>, SegmentErrorInfo> errorCache);
+ @Nullable Cache<Pair<String, String>, SegmentErrorInfo> errorCache,
+ SegmentPreprocessThrottler segmentPreprocessThrottler);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
