ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered
Storage
URL: https://github.com/apache/pulsar/pull/2865#discussion_r241368523
##########
File path:
tests/integration/src/test/java/org/apache/pulsar/tests/integration/suites/PulsarTieredStorageTestSuite.java
##########
@@ -58,8 +58,8 @@ public void setupCluster() throws Exception {
brokerContainer.withEnv("managedLedgerMaxEntriesPerLedger",
String.valueOf(ENTRIES_PER_LEDGER));
brokerContainer.withEnv("managedLedgerMinLedgerRolloverTimeMinutes", "0");
brokerContainer.withEnv("managedLedgerOffloadDriver", "s3");
- brokerContainer.withEnv("bucket", "pulsar-integtest");
- brokerContainer.withEnv("endpoint", "http://"; + S3Container.NAME +
":9090");
+ brokerContainer.withEnv("s3ManagedLedgerOffloadBucket",
"pulsar-integtest");
Review comment:
It would be good to test both the BC version and the variants.
Maybe ```
if (i++ % 2) {
// use BC variant
} else {
// use new variant
}
```
Kinda messy though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
