ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered
Storage
URL: https://github.com/apache/pulsar/pull/2865#discussion_r241367828
##########
File path:
tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloaderBase.java
##########
@@ -122,10 +122,10 @@ protected static Credentials getBlobStoreCredentials() {
protected TieredStorageConfiguration getConfiguration(String bucket) {
Map<String, String> metaData = new HashMap<String, String> ();
- metaData.put(TieredStorageConfiguration.BLOB_STORE_PROVIDER_KEY,
provider.name());
- metaData.put(TieredStorageConfiguration.METADATA_FIELD_REGION, "");
- metaData.put(TieredStorageConfiguration.METADATA_FIELD_BUCKET, bucket);
- metaData.put(TieredStorageConfiguration.METADATA_FIELD_ENDPOINT, "");
+ metaData.put(TieredStorageConfiguration.BLOB_STORE_PROVIDER_KEY,
provider.getDriver());
+ metaData.put("managedLedgerOffload." +
TieredStorageConfiguration.METADATA_FIELD_REGION, "");
Review comment:
The prefix is defined as a constant in TieredStorageConfiguration, so that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
