ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r242291123
########## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/suites/PulsarTieredStorageTestSuite.java ########## @@ -58,8 +58,8 @@ public void setupCluster() throws Exception { brokerContainer.withEnv("managedLedgerMaxEntriesPerLedger", String.valueOf(ENTRIES_PER_LEDGER)); brokerContainer.withEnv("managedLedgerMinLedgerRolloverTimeMinutes", "0"); brokerContainer.withEnv("managedLedgerOffloadDriver", "s3"); - brokerContainer.withEnv("bucket", "pulsar-integtest"); - brokerContainer.withEnv("endpoint", "http://" + S3Container.NAME + ":9090"); + brokerContainer.withEnv("s3ManagedLedgerOffloadBucket", "pulsar-integtest"); Review comment: PulsarTieredStorageTestSuite is a base class used by TestS3Offload. So adding a new TestSuite class would be kinda messy. I'm happy enough to keep it as it is now. When you add azure, I assume there'll be some tests that use the new values. These values get passed as environment values to the docker containers which run the tests. The docker containers go through each environment variable, sees if it matches a field in the configuration file (like broker.conf), and if so updates that field. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services