Anonymitaet commented on a change in pull request #4374: [rest] improve
clusters rest endpoint by documenting the endpoints with more swagger
annotations
URL: https://github.com/apache/pulsar/pull/4374#discussion_r287592759
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
##########
@@ -135,11 +186,37 @@ public void createCluster(@PathParam("cluster") String
cluster, ClusterData clus
@POST
@Path("/{cluster}")
- @ApiOperation(value = "Update the configuration for a cluster.", notes =
"This operation requires Pulsar super-user privileges.")
- @ApiResponses(value = { @ApiResponse(code = 204, message = "Cluster has
been updated"),
- @ApiResponse(code = 403, message = "Don't have admin permission"),
- @ApiResponse(code = 404, message = "Cluster doesn't exist") })
- public void updateCluster(@PathParam("cluster") String cluster,
ClusterData clusterData) {
+ @ApiOperation(
+ value = "Update the configuration for a cluster.",
+ notes = "This operation requires Pulsar super-user privileges.")
+ @ApiResponses(value = {
+ @ApiResponse(code = 204, message = "Cluster has been updated"),
+ @ApiResponse(code = 403, message = "Don't have admin permission or
policies are readonly"),
Review comment:
```suggestion
@ApiResponse(code = 403, message = "Don't have admin permission
or policies are read-only"),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
