Anonymitaet commented on a change in pull request #4374: [rest] improve 
clusters rest endpoint by documenting the endpoints with more swagger 
annotations
URL: https://github.com/apache/pulsar/pull/4374#discussion_r287594333
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
 ##########
 @@ -684,11 +965,28 @@ public FailureDomain getDomain(@PathParam("cluster") 
String cluster, @PathParam(
 
     @DELETE
     @Path("/{cluster}/failureDomains/{domainName}")
-    @ApiOperation(value = "Delete cluster's failure omain")
-    @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have 
admin permission or plicy is read only"),
-            @ApiResponse(code = 412, message = "Cluster doesn't exist") })
-    public void deleteFailureDomain(@PathParam("cluster") String cluster, 
@PathParam("domainName") String domainName)
-            throws Exception {
+    @ApiOperation(
+        value = "Delete cluster's failure domain",
 
 Review comment:
   ```suggestion
           value = "Delete the failure domain of the cluster",
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to