Anonymitaet commented on a change in pull request #4374: [rest] improve 
clusters rest endpoint by documenting the endpoints with more swagger 
annotations
URL: https://github.com/apache/pulsar/pull/4374#discussion_r287594777
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
 ##########
 @@ -596,12 +824,34 @@ public void 
deleteNamespaceIsolationPolicy(@PathParam("cluster") String cluster,
 
     @POST
     @Path("/{cluster}/failureDomains/{domainName}")
-    @ApiOperation(value = "Set cluster's failure Domain")
-    @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have 
admin permission"),
-            @ApiResponse(code = 409, message = "Broker already exists in 
another domain"),
-            @ApiResponse(code = 404, message = "Cluster doesn't exist") })
-    public void setFailureDomain(@PathParam("cluster") String cluster, 
@PathParam("domainName") String domainName,
-            FailureDomain domain) throws Exception {
+    @ApiOperation(
+        value = "Set cluster's failure Domain",
 
 Review comment:
   ```suggestion
           value = "Set the failure domain of the cluster",
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to