BewareMyPower commented on code in PR #19944:
URL: https://github.com/apache/pulsar/pull/19944#discussion_r1153963425
##########
pulsar-common/src/main/proto/PulsarApi.proto:
##########
@@ -62,9 +62,9 @@ message MessageIdData {
optional int32 batch_index = 4 [default = -1];
repeated int64 ack_set = 5;
optional int32 batch_size = 6;
-
// For the chunk message id, we need to specify the first chunk message id.
optional MessageIdData first_chunk_message_id = 7;
+ optional string topicName = 8;
Review Comment:
I think we need a PIP to add new fields to the Pulsar API. In
[PIP-224](https://github.com/apache/pulsar/issues/18616) I proposed to add an
extra class `TopicMessageIdSerDes` for the serialization of the
`TopicMessageId`, but the related PR is not present yet. If we can introduce
such a new field, I think we don't need to implement `TopicMessageIdSerDes` any
more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
