coderzc commented on code in PR #21745:
URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436861554


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PulsarCompactorSubscription.java:
##########
@@ -106,5 +108,16 @@ public void markDeleteFailed(ManagedLedgerException 
exception, Object ctx) {
         }
     }
 
+    CompletableFuture<Void> cleanCompactedLedger() {

Review Comment:
   This PR is just to fix this old problem, it needs to be cherry-picked to 
release branch, I think we can separately propose a PIP extending 
TopicCompactionService on the later version.



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PulsarCompactorSubscription.java:
##########
@@ -106,5 +108,16 @@ public void markDeleteFailed(ManagedLedgerException 
exception, Object ctx) {
         }
     }
 
+    CompletableFuture<Void> cleanCompactedLedger() {

Review Comment:
   This PR is just to fix this old problem, it needs to be cherry-picked to the 
release branch, I think we can separately propose a PIP extending 
TopicCompactionService on the later version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to