coderzc commented on code in PR #21745:
URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436996424


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1220,7 +1221,7 @@ private void 
asyncDeleteCursorWithClearDelayedMessage(String subscriptionName,
                     if (ex != null) {
                         unsubscribeFuture.completeExceptionally(ex);
                     } else {

Review Comment:
   @poorbarcode I added wait for current compaction finished before delete the 
cursor, and due to `cursor.props` will be updated after opening compaction 
ledger, so I get compactionLedgerId from `compactedTopicContext` and set 
`ackReceiptEnabled=true` of RawReader.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to