poorbarcode commented on code in PR #21745:
URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436950722


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1220,7 +1221,7 @@ private void 
asyncDeleteCursorWithClearDelayedMessage(String subscriptionName,
                     if (ex != null) {
                         unsubscribeFuture.completeExceptionally(ex);
                     } else {

Review Comment:
   @coderzc 
   
   > Force delete topic will disconnect all connections, and the compaction 
task will fail. I think we can ignore this case.
   
   Maybe the in-progress Compaction task is trying to update the 
`cursor.props`?  For example:
   - The Last ledger of Compacted data is `1`
   - Start Compaction task
   - Delete topic
     - delete ledger `1`
   - Update the last ledger of Compacted data to `2`
     - update success
   - Delete cursor success
   
   There is an orphan ledger `2`   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to