dao-jun commented on code in PR #22221:
URL: https://github.com/apache/pulsar/pull/22221#discussion_r1519526546
##########
pulsar-common/src/main/java/org/apache/pulsar/common/mutable/AtomicMutableBoolean.java:
##########
@@ -0,0 +1,165 @@
+package org.apache.pulsar.common.mutable;
+
+import org.apache.commons.lang3.BooleanUtils;
+import org.apache.commons.lang3.mutable.MutableBoolean;
+
+public class AtomicMutableBoolean extends MutableBoolean {
Review Comment:
why do we need the class?
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java:
##########
@@ -200,7 +210,7 @@ public void addComplete(int rc, final LedgerHandle lh, long
entryId, Object ctx)
lh == null ? -1 : lh.getId(), entryId, dataLength, rc);
}
- if (rc != BKException.Code.OK) {
+ if (rc != BKException.Code.OK || timeoutTriggered.isTrue()) {
Review Comment:
It will lead to switch to a new ledger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
